-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dummy node logic #187
Dummy node logic #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a quick review of the PR. I still need to test the PR locally
Can you also update the input/readme with information about the dummy file and dummy column in the prizes file |
If I try to use an updated dummy nodes file (dummy-1.txt) with the original sources, targets, and node-prizes files, I get this error:
this is what my config file looks like for the datasets
this is what I updated dummy-1.txt to be: |
Could you also add tests to the OI1 testing sweep that test's the run function using the dummy nodes There is a chance you will need to update the generate inputs test sweep as well (still need to think through if you really do). |
@ntalluri |
Can you also run |
Running that gave me this: '[INFO] Initializing environment for https://github.com/charliermarsh/ruff-pre-commit.
Fixing spras/omicsintegrator1.py ruff.....................................................................Failed
Found 1 error (1 fixed, 0 remaining).' what's the |
I think this is referring to this https://docs.astral.sh/ruff/, which is a linter and code formatter that pre-commit will use that was specified in the .pre-commit-config.yaml file but that pre-commit message looks good due to this message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a round of comments. I haven't run it locally yet.
Let's think of at least one test case we can add that will run Omics Integrator 1 with a dummy node file.
This will close #62 when merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with datasets that had dummy nodes and others that did not, and everything appeared to work. I also added simple test cases.
No description provided.